Tidy up project metadata fetching #130130
Merged
+10
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joegallo
added
>non-issue
Team:Distributed Coordination
Collaborator
|
Pinging @elastic/es-distributed-coordination (Team:Distributed Coordination) |
nielsbauman
approved these changes
Jun 26, 2025
Contributor
nielsbauman
left a comment
nielsbauman
left a comment
There was a problem hiding this comment.
LGTM, thanks for fixing these, Joe!
smalyshev
pushed a commit
to smalyshev/elasticsearch
that referenced
this pull request
Jun 27, 2025
mridula-s109
pushed a commit
to mridula-s109/elasticsearch
that referenced
this pull request
Jul 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a search and replace for some places where we can avoid allocating a
ProjectStateor can lean more heavily on different methods to conserve precious characters. As far as I'm aware there shouldn't be any change in behavior, but if I'm wrong about that then I guess I'll learn something.